Handle badly named version files more gracefully and log information

[come-nc]

Fix #34085

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

[PVince81]

@come-nc can you add an example file name ? (ideal would be in unit tests if possible)

any explanation why this is happening at all ? does PHP parse extensions differently in some versions ?

[blizzz]

master is 26 👀

[come-nc]

@come-nc can you add an example file name ? (ideal would be in unit tests if possible)

any explanation why this is happening at all ? does PHP parse extensions differently in some versions ?

To my knowledge this can only happen if there is a file in files_version with an incorrect name, but it’s better to log that correctly. See the linked issue.

PHP does not parse extension differently, but trying to access $array['undefinedkey'] was a silent error before PHP 8 if I recall correctly.

[come-nc]

/backport to stable25

[come-nc]

/backport to stable24

[come-nc]

/backport to stable23

[PVince81]

👍

[come-nc]

CI failure unrelated

[come-nc]

Tagging this do not merge until I understand the actual source of the problem, might as well fix the real issue.

[come-nc]

Tagging this do not merge until I understand the actual source of the problem, might as well fix the real issue.

Ok, I am reopening this for merging.
It appears the original ticket is caused by bad behavior of groupfolders application.
This should help have a better understanding of the error in such cases.

[szaimen]

LGTM but didnt test

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable24 failed. Please do this backport manually.

[backportbot-nextcloud]

The backport to stable23 failed. Please do this backport manually.