Fix reference preview when no server-side cache configured#34450
Merged
nickvergessen merged 1 commit intomasterfrom Oct 14, 2022
Merged
Fix reference preview when no server-side cache configured#34450nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/noid/opengraph-preview-without-cache
branch
from
b568f9a to
6e03d99
Compare
juliusknorr
approved these changes
Oct 13, 2022
Member
|
/backport to stable25 |
julien-nc
requested review from
a team,
CarlSchwan and
icewind1991
and removed request for
a team
nickvergessen
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short version: We can't rely on cached values to get the link preview image file type.
Long version:
Currently, when getting a reference image preview with
/core/references/preview/REF_CACHE_KEYwe use the info we have to build the DataResponse:LinkReferenceProvider::fetchReference()and stored in appDataProblem is if no server side cache is configured we don't cache the reference so basically the preview endpoint does not work 😁.
That leaves us with 2 potential solutions:
application/octet-streammost likely because ourFile::getMimeType()is based on file name extension and there is none for those files. Browsers are fine with that though...