Fix positioning of the public page footer#34396
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Merged
juliusknorr
requested review from
a team,
PVince81,
artonge and
szaimen
and removed request for
a team
szaimen
requested changes
Oct 3, 2022
9 tasks
vinicius73
approved these changes
Oct 3, 2022
Member
vinicius73
left a comment
vinicius73
left a comment
There was a problem hiding this comment.
Revert it for now to fix the broken CI
This was referenced Oct 3, 2022
Contributor
|
/compile amend / |
szaimen
reviewed
Oct 3, 2022
|
|
||
|
|
||
| .app-files_sharing #app-content footer { | ||
| position: sticky !important; |
Contributor
There was a problem hiding this comment.
do you think this will work or will we need to make an exceptioni here for txt or md files?
Contributor
There was a problem hiding this comment.
at least it works for other file types in my testing...
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
bugfix/noid/public-page-footer
branch
from
9b82a30 to
864b1ca
Compare
Member
|
Works @szaimen <3 |
Member
|
It this CI error related to this PR @juliushaertl @szaimen |
Contributor
the error is unrelated afaics |
szaimen
approved these changes
Oct 3, 2022
Contributor
|
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #34399
Fixes the regression mentioned in #34331 that the footer would be positioned a the page top.