Skip to content

Rewrite admin theming in Vue#34359

Merged
skjnldsv merged 2 commits intomasterfrom
enh/admin-theming-vue
Oct 28, 2022
Merged

Rewrite admin theming in Vue#34359
skjnldsv merged 2 commits intomasterfrom
enh/admin-theming-vue

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Oct 1, 2022 •
edited
Loading

image

Move away from the legacy PHP implementation to improve UX parity for user and admin theming + enhance accessibility

  • Fix background preview showing user background
  • Fix unable to set plain background and usage on login page

Requires

Before

image

@Pytal Pytal added the 2. developing Work in progress label Oct 1, 2022
@Pytal Pytal self-assigned this Oct 1, 2022
@Pytal Pytal force-pushed the enh/admin-theming-vue branch 5 times, most recently from 20de993 to f57351c Compare October 6, 2022 04:48
@Pytal Pytal changed the title [WIP] Rewrite admin theming in Vue Rewrite admin theming in Vue Oct 6, 2022
@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming feature: accessibility accessibility and removed 2. developing Work in progress labels Oct 6, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Oct 6, 2022
@Pytal
Copy link
Member Author

Pytal commented Oct 6, 2022

Keeping as draft until required PRs are in

@Pytal Pytal mentioned this pull request Oct 6, 2022
Merged
@blizzz blizzz mentioned this pull request Oct 6, 2022
Merged
3 tasks
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Oct 6, 2022
@blizzz
Copy link
Member

blizzz commented Oct 6, 2022

master is 26

@Pytal
Copy link
Member Author

Pytal commented Oct 6, 2022

/backport to stable25

@Pytal Pytal force-pushed the enh/admin-theming-vue branch from f57351c to 84778df Compare October 7, 2022 04:46
@Pytal Pytal force-pushed the enh/admin-theming-vue branch from 84778df to 6f84493 Compare October 8, 2022 02:43
@Pytal Pytal mentioned this pull request Oct 11, 2022
Closed
4 tasks
@Pytal Pytal force-pushed the enh/admin-theming-vue branch from 6f84493 to a429d7f Compare October 12, 2022 03:15
@PVince81 PVince81 mentioned this pull request Oct 12, 2022
Closed
@Pytal Pytal force-pushed the enh/admin-theming-vue branch from a429d7f to dbec140 Compare October 13, 2022 01:04
@Pytal Pytal force-pushed the enh/admin-theming-vue branch from 8569f70 to 94a415f Compare October 27, 2022 01:15
@szaimen
Copy link
Contributor

szaimen commented Oct 27, 2022

@jancborchardt I have the feeling that the text fields are too long bases on the screenshot. Wdyt?

@szaimen
Copy link
Contributor

szaimen commented Oct 27, 2022

@Pytal @CarlSchwan wasnt there a max element widht applied to all settings sections automatically?

@skjnldsv
Copy link
Member

skjnldsv commented Oct 27, 2022

@szaimen no, but the input were set to width: 230px;

@skjnldsv skjnldsv marked this pull request as ready for review October 27, 2022 08:18
@skjnldsv skjnldsv requested review from a team, artonge, skjnldsv and szaimen and removed request for a team October 27, 2022 08:18
@szaimen
Copy link
Contributor

szaimen commented Oct 27, 2022

Drone failure related

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 27, 2022
@Pytal Pytal force-pushed the enh/admin-theming-vue branch from 94a415f to bbccae2 Compare October 27, 2022 23:48
Pytal added 2 commits October 28, 2022 00:18
@Pytal
Rewrite admin theming in Vue
4a2bbc7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Purge unused legacy code and drop 3rdparty jscolor dependency
9ec32a7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/admin-theming-vue branch from bbccae2 to 9ec32a7 Compare October 28, 2022 00:19
@Pytal
Copy link
Member Author

Pytal commented Oct 28, 2022

@jancborchardt I have the feeling that the text fields are too long bases on the screenshot. Wdyt?

Text fields have been set to max-width: 400px (updated screenshot) like in

server/apps/settings/src/components/PasswordSection.vue

Line 96 in c723daa

max-width: 400px;
and other settings

@Pytal @CarlSchwan wasnt there a max element widht applied to all settings sections automatically?

@szaimen no, but the input were set to width: 230px;

Yes 900px was for the entire settings section in nextcloud-libraries/nextcloud-vue#3192, 230px was specifically for these inputs

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 28, 2022
@Pytal
Copy link
Member Author

Pytal commented Oct 28, 2022

⚠ Do not merge until the https://github.com/nextcloud/nextcloud-vue additions (undo icon and maxlength attribute) are available on server

@skjnldsv
Copy link
Member

skjnldsv commented Oct 28, 2022

I would prefer to merge and wait for the next vue version, or else we'll keep rebasing this PR over and over :(

@szaimen
Copy link
Contributor

szaimen commented Oct 28, 2022

I would prefer to merge and wait for the next vue version, or else we'll keep rebasing this PR over and over :(

+1

@skjnldsv skjnldsv merged commit 3323b1a into master Oct 28, 2022
@skjnldsv skjnldsv deleted the enh/admin-theming-vue branch October 28, 2022 09:48
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 28, 2022

The backport to stable25 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

skjnldsv commented Oct 28, 2022

We said no backports in the end iirc :)

@skjnldsv skjnldsv mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc. enhancement feature: accessibility feature: theming

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

6 participants

@Pytal @blizzz @skjnldsv @PVince81 @szaimen @artonge