Merged
Conversation
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Valdnet
added
the
feature: language/translations (l10n/i18n)
rakekniven
approved these changes
Sep 17, 2022
Member
|
/compile amend / |
Member
|
Please change the text in https://github.com/nextcloud/server/blob/master/core/js/tests/specs/setupchecksSpec.js test file as well ( |
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
Valdnet-patch-3
branch
from
3fc5516 to
a9f20b9
Compare
CarlSchwan
approved these changes
Sep 19, 2022
CarlSchwan
reviewed
Sep 19, 2022
Contributor
Author
|
Tests fixed 😉. |
Member
|
Not fully yet Expected 'Fourty Two (Invisible)' to equal 'Fourty Two (invisible)'. |
Member
|
Those ones are in |
Contributor
Author
|
@tcitworld @CarlSchwan Thanks for pointing out the test error 😉. Test fixed. |
tcitworld
approved these changes
Sep 19, 2022
Member
|
Test failure is unrelated (phpunit/dav)
END:VCALENDAR' |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Valdnet 47037905+Valdnet@users.noreply.github.com