Show Nextcloud Hub 3 in overview page when applicable#34066
Merged
Conversation
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
requested review from
AndyScherzinger,
CarlSchwan,
artonge,
blizzz and
skjnldsv
AndyScherzinger
approved these changes
Sep 14, 2022
CarlSchwan
approved these changes
Sep 14, 2022
szaimen
reviewed
Sep 14, 2022
| <div id="version" class="section"> | ||
| <!-- should be the last part, so Updater can follow if enabled (it has no heading therefore). --> | ||
| <h2><?php p($l->t('Version'));?></h2> | ||
| <?php if ($theme->getTitle() === 'Nextcloud'): ?> |
Contributor
There was a problem hiding this comment.
what is the difference between $theme->getTitle and $theme->getName?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar pattern we used before: https://github.com/nextcloud/server/blob/v23.0.4/apps/settings/templates/settings/admin/overview.php#L70
Please note that it's not possible to hard-code this title in \OC_Defaults because the title itself needs special formatting of the version, otherwise it doesn't look good as
Nextcloud Hub 3 25.0.0 beta6=>Nextcloud Hub (25.0.0 beta 6)