merge last_activity and last_check updates#34056
Closed
icewind1991 wants to merge 1 commit intomasterfrom
Closed
Conversation
7217c0c to
7d434e8
Compare
Member
Author
|
I've done some basic testing to ensure that both |
7d434e8 to
f012969
Compare
Merged
ChristophWurst
approved these changes
Sep 16, 2022
Merged
Merged
Merged
Contributor
|
I do not have enought understanding/knowledge to approve this, sorry |
f012969 to
491f058
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
491f058 to
568c4b4
Compare
the debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period. Signed-off-by: Robin Appelman <[email protected]>
568c4b4 to
f6d18f8
Compare
susnux
approved these changes
Jun 21, 2024
Contributor
susnux
left a comment
There was a problem hiding this comment.
Looks good from my understanding, very clean!
Contributor
|
But the test needs to be adjusted @icewind1991 |
Member
|
Wasn't this addressed with #45026? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateActivityhas been updated to also write any other changed field.the debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period.
This is pretty much a 2nd version of #1037, which was reverted(#29682) after the
last_activityupdating changed by #29357