Use new vue components in login form#33781
Merged
CarlSchwan merged 2 commits intomasterfrom Sep 6, 2022
Merged
Conversation
Member
|
master now has the vue components bump :) |
- Improve accessibility - Simply code Signed-off-by: Carl Schwan <[email protected]>
37b8615 to
c12c5ce
Compare
c12c5ce to
292bd8d
Compare
nimishavijay
approved these changes
Sep 5, 2022
Member
nimishavijay
left a comment
There was a problem hiding this comment.
Looks good design wise!
Maybe this is irrelevant to this PR but 2 primary buttons close to each other is generally avoided, instead the Login with Keycloak button can have secondary button styling.
Member
Author
292bd8d to
bbd0d42
Compare
bbd0d42 to
1351ad1
Compare
skjnldsv
approved these changes
Sep 6, 2022
Member
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice! Just 2 details, possibly separate issues from this:
-
Wording-wise we want to get away from saying "user" so should be "account name or email" here
-
Not sure if it was introduced with this, but container has more space to the top than to the left
- Move css in scopped vue components - Port to NcNoteCard all the warning messages Signed-off-by: Carl Schwan <[email protected]>
1351ad1 to
43d1aa3
Compare
Member
Author
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Close #33822
Error handling: