Use display name cache on getStorageInfo

[juliusknorr]

While the method result is cached, it still might save a query from time to time and is less code than before

[PVince81]

👍

[juliusknorr]

Will have a look at the failing tests

[juliusknorr]

One more remaining:

[Mon Aug 29 06:43:51 2022] {"Exception":"Exception","Message":"Argument 1 passed to OC\\User\\Manager::getDisplayName() must be of the type string, null given, called in \/drone\/src\/lib\/private\/legacy\/OC_Helper.php on line 545 in file '\/drone\/src\/lib\/private\/User\/Manager.php' line 191","Code":0,"Trace":[{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/src\/lib\/base.php","line":1042,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/src\/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","Line":165,"Previous":{"Exception":"TypeError","Message":"Argument 1 passed to OC\\User\\Manager::getDisplayName() must be of the type string, null given, called in \/drone\/src\/lib\/private\/legacy\/OC_Helper.php on line 545","Code":0,"Trace":[{"file":"\/drone\/src\/lib\/private\/legacy\/OC_Helper.php","line":545,"function":"getDisplayName","class":"OC\\User\\Manager","type":"->"},{"file":"\/drone\/src\/apps\/files\/lib\/Controller\/ViewController.php","line":155,"function":"getStorageInfo","class":"OC_Helper","type":"::"},{"file":"\/drone\/src\/apps\/files\/lib\/Controller\/ViewController.php","line":205,"function":"getStorageInfo","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":225,"function":"index","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":133,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/src\/lib\/base.php","line":1042,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/src\/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/drone\/src\/lib\/private\/User\/Manager.php","Line":191},"CustomMessage":"--"}

[juliusknorr]

/rebase

[PVince81]

/rebase

[PVince81]

/backport to stable25