CSS changes for better distinction between user name and full name in user list

[Jerome-Herbinet]

Signed-off-by: Jérôme Herbinet [email protected]

Signed-off-by: Jérôme Herbinet [email protected]

[szaimen]

Lgtm but didn't test

[Jerome-Herbinet]

What is in the commit branch ? is this normal ? any problem ?
3rdparty
Viewed
Submodule 3rdparty updated 164 files

[jancborchardt]

Good idea! Some design feedback:

• We never use italic cause it is not so easily legible
• Instead, we could bold the display name
• Display name should show in first row, then account name, so it doesn't look weird with a bold subline
• That variable looks non-standard, we only use either color-main-text or color-text-maxcontrast. But if we bold the display name, we don't need to reduce the color of the account name.

[szaimen]

What is in the commit branch ? is this normal ? any problem ? 3rdparty Viewed Submodule 3rdparty updated 164 files

This change needs to be reverted. See https://stackoverflow.com/questions/30275691/removing-subproject-commit-from-github/30275888#30275888

[Jerome-Herbinet]

@szaimen I think I've removed it ; can you tell me if it's OK ? (submodule)

[Jerome-Herbinet]

Good idea! Some design feedback:

* [ ]  We never use italic cause it is not so easily legible

* [ ]  Instead, we could bold the display name

* [ ]  Display name should show in first row, then account name, so it doesn't look weird with a bold subline

* [ ]  That variable looks non-standard, we only use either color-main-text or color-text-maxcontrast. But if we bold the display name, we don't need to reduce the color of the account name.

@jancborchardt thanks for your suggestions ; I'll take care of it.

[Jerome-Herbinet]

• following

[szaimen]

hm... seems like following my link removed too much :/

@skjnldsv do you know how to fix that?

[skjnldsv]

Nope :(

[Jerome-Herbinet]

@StCyr une idée ?

[szaimen]

@Jerome-Herbinet thanks! Can you please post a new screenshot? That would be great!

[Jerome-Herbinet]

@Jerome-Herbinet thanks! Can you please post a new screenshot? That would be great!

@szaimen here it is :

[szaimen]

cc @jancborchardt

[jancborchardt]

@Jerome-Herbinet almost :) could you:

• Unbold the account name, as the display name is already bold
• Put display name in the first line, accoint in the second (not soo important if difficult)

[Jerome-Herbinet]

@Jerome-Herbinet almost :) could you:

* Unbold the account name, as the display name is already bold

* Put display name in the first line, accoint in the second (not soo important if difficult)

@jancborchardt in fact the text isn't bold ; the other screenshot boldness is certainly due to the default font of my Ubuntu Laptop.

Here is a screenshot of the same NC instance, under Manjaro.

So do you want me to bold something ?

And about putting the display name in first position, I won't be able to do it my self (sorry).

[jancborchardt]

@Jerome-Herbinet ah got it, thanks for the screenshot! Then I'd only say it would be nice to bold the display name (best use a <strong> tag for semantic markup).

[Jerome-Herbinet]

@Jerome-Herbinet ah got it, thanks for the screenshot! Then I'd only say it would be nice to bold the display name (best use a \<strong\> tag for semantic markup).

Done @jancborchardt

Display name is bold ... event if on my "day" computer, difference between bold and not bold texte isn't very visible ... (with "strong") and display name and user name are inverted now.

[Jerome-Herbinet]

As a newbie as code contributor, I made an error, by committing 5f9962d ... I think I've cancelled it, can you confirm ? (sorry for the mess, I'm learning).

[Jerome-Herbinet]

I'm concerned about submodule problem ; do you have a tip to solve it ?

[Jerome-Herbinet]

Hello,
If the Submodule problem is not solvable, do you advise me to close this PR and to create a new one (hopping that it will work better) ?

[szaimen]

If the Submodule problem is not solvable, do you advise me to close this PR and to create a new one (hopping that it will work better) ?

Yesy that is probably a good idea. Thanks!

[Jerome-Herbinet]

If the Submodule problem is not solvable, do you advise me to close this PR and to create a new one (hopping that it will work better) ?

Yesy that is probably a good idea. Thanks!

OK @szaimen, I close it and tell you when the new PR is created (I'll cross the fingers).

[Jerome-Herbinet]

New PR --> #34163