Fix plural translation without %n usage in string#33635
Closed
ChristophWurst wants to merge 1 commit intomasterfrom
Closed
Fix plural translation without %n usage in string#33635ChristophWurst wants to merge 1 commit intomasterfrom
ChristophWurst wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
CarlSchwan,
Valdnet,
blizzz,
nickvergessen and
vitormattos
ChristophWurst
changed the title
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
|
Why can't the string be fixed to use |
Member
Failing some tests now |
Member
|
Basically 16d4ff4 is buggy as it uses n() without using the plural placeholder. Should be fixed there instead? |
Member
|
Proper fix in #33639 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32745.
The issue is that the translation string
_%s user found_::_%s users found_doesn't contain a%n, so it was wrongly assumed that this isn't a plural string and so the counter didn't get passed to Symfony. Symfony then didn't bother to split the plural string at|and the final text passed tovsprintfcontained two%s.The code now uses the
|as indicator for a plural string.Test added to reproduce the issue and confirm the fix.
Ref #26375
Ref #32155