Remove the loop of calendars when only one is needed#33608
Merged
Conversation
tcitworld
reviewed
Aug 18, 2022
kesselb
reviewed
Aug 22, 2022
tcitworld
approved these changes
Aug 23, 2022
Member
There was a problem hiding this comment.
Good enough for now, but I suggest the following to make psalm happy properly (possibly as an extra PR):
- Add a new interface DirectURIAccess providing the
getCalendarByUriandgetSubscriptionByUri. - Implement
getSubscriptionByUriin CalDAV backend - This allows to do pretty much the same for subscriptions below (more speed ⚡ )
- Put all of this into a
if ($this->caldavBackend instanceof DirectURIAccess)check so that psalm is happy and we're keeping things clean).
Member
|
Testing trashbin should work the same btw, through a |
Member
|
Still some failures in drone |
e8fff40 to
b196f4c
Compare
ChristophWurst
approved these changes
Sep 5, 2022
Contributor
Author
|
Drone failures with file sharing acceptance tests (unrelated?) |
Member
|
Maybe a rebase can tell? |
b196f4c to
2f0d6f7
Compare
Member
|
Rebased to (hopefully) fix tests. |
Member
|
Drone restarted |
2f0d6f7 to
47025d4
Compare
Member
|
Linter is unhappy |
Signed-off-by: Anna Larch <anna@nextcloud.com>
47025d4 to
3a8c7b6
Compare
Contributor
Author
|
Drone failure due to: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33599