delay getting the home dir of a user untill needed#33597
Closed
icewind1991 wants to merge 1 commit intomasterfrom
Closed
delay getting the home dir of a user untill needed#33597icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
CarlSchwan and
skjnldsv
and removed request for
a team
CarlSchwan
approved these changes
Aug 18, 2022
Merged
PVince81
reviewed
Aug 23, 2022
| } | ||
|
|
||
| public function getSourcePath($path) { | ||
| if ($this->datadir == '/tmp/empty/placeholder/') { |
Member
There was a problem hiding this comment.
use a constant ?
should we use a value even more cryptic ?
Merged
Member
|
conflict |
PVince81
added
2. developing
icewind1991
force-pushed
the
home-storage-lazy-datadir
branch
2 times, most recently
from
4c996f6 to
c931399
Compare
Member
|
/rebase |
for cache-only operations we don't actually need to know the home directory Signed-off-by: Robin Appelman <robin@icewind.nl>
nextcloud-command
force-pushed
the
home-storage-lazy-datadir
branch
from
c931399 to
612b2a4
Compare
Member
|
Contributor
|
@icewind1991 please fix the test |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for cache-only operations we don't actually need to know the home directory
Signed-off-by: Robin Appelman robin@icewind.nl