Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
|
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @MorrisJobke and @luckydonald to be potential reviewers. |
skjnldsv
requested review from
ChristophWurst,
LukasReschke,
MorrisJobke,
jancborchardt and
nickvergessen
MorrisJobke
approved these changes
Feb 1, 2017
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works really nice 👍
Codecov Report@@ Coverage Diff @@
## master #3353 +/- ##
============================================
+ Coverage 53.98% 53.99% +<.01%
============================================
Files 1303 1303
Lines 80377 80377
Branches 1253 1253
============================================
+ Hits 43394 43397 +3
+ Misses 36983 36980 -3
Continue to review full report at Codecov.
|
Member
|
Awesome work! (was on vacation last week hence the late reply :D) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3185
Added two width settings for the mobile view activation
Mobile view:
screen<688AND769<screen<938Reasons: since the table has a min-width, there was a small transition where the table will be cut on the left (between the 688 min width and the 768px width when the app-navigation sidebar is hidden)
@nextcloud/designers