Backend for reference metadata fetching#33494
Merged
juliusknorr merged 12 commits intomasterfrom Aug 31, 2022
Merged
Conversation
4b2fb66 to
445ea5f
Compare
445ea5f to
84437c2
Compare
84437c2 to
7dba179
Compare
Contributor
|
It took me so long to understand what this is about, so, for other unaware reviewers: And this is the backend part, is not specific to Talk, and may not be specific to links in the future, which is what makes the original description convoluted. |
Member
Author
|
Sorry, should have clarified that a bit more, but I've taken your description for the first post in addition |
come-nc
reviewed
Aug 29, 2022
marcelklehr
reviewed
Aug 29, 2022
4 tasks
juliusknorr
commented
Aug 30, 2022
come-nc
reviewed
Aug 30, 2022
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
424020a to
94ee906
Compare
CarlSchwan
approved these changes
Aug 31, 2022
CarlSchwan
reviewed
Aug 31, 2022
lib/private/Collaboration/Reference/File/FileReferenceProvider.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Julius Härtl <jus@bitgrid.net>
94ee906 to
1ab6698
Compare
Member
Author
|
Failures unrelated |
come-nc
reviewed
Sep 1, 2022
Comment on lines
+45
to
+50
| /** | ||
| * Return true if the reference metadata can be globally cached | ||
| * | ||
| * @since 25.0.0 | ||
| */ | ||
| public function getCachePrefix(string $referenceId): string; |
Contributor
There was a problem hiding this comment.
The phpdoc description is wrong
This was referenced Sep 1, 2022
This was referenced Sep 27, 2022
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is about showing a preview of links posted in Talk, like what is done when posting links on other chat platforms.
And this is the backend part, is not specific to Talk, and may not be specific to links in the future, which is what makes the original description convoluted.
This PR implements an API to be used to generate a rich preview rendering of references (which are links in the first iteration). The backend gathers additional metadata for references through different providers, which can be added by apps, but there is a fallback to an open graph provider by default. The open graph extraction can be turned off through config.php.
ToDo
Backend
Integration
Provider implementations