Merged
Conversation
jancborchardt
approved these changes
Aug 2, 2022
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks nice design-wise! :)
cc @marcoambrosini since you worked on the TextInput – are you good with how it looks together with the button?
marcoambrosini
approved these changes
Aug 2, 2022
Member
There was a problem hiding this comment.
lgtm too, but shouldn't we wait for the input component and use that @CarlSchwan?
Merged
Member
Author
|
NcPasswordField is now merged, just need a new release of the nextcloud vue library ;) |
Merged
CarlSchwan
changed the title
CarlSchwan
force-pushed
the
port-password-vue
branch
2 times, most recently
from
58baee9 to
8b79cdd
Compare
CarlSchwan
added
4. to release
CarlSchwan
force-pushed
the
port-password-vue
branch
2 times, most recently
from
84c369f to
e8a94af
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
port-password-vue
branch
from
e8a94af to
60c4291
Compare
Member
Author
|
Ci failures unrelated |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.