#33036 [Bug]: Set default expiration date#33396
Merged
PVince81 merged 1 commit intonextcloud:masterfrom Sep 1, 2022
Xavierando:#33036-Set-default-expiration-date-(shareapiDefaultExpireDate)
Merged
#33036 [Bug]: Set default expiration date#33396PVince81 merged 1 commit intonextcloud:masterfrom Xavierando:#33036-Set-default-expiration-date-(shareapiDefaultExpireDate)
PVince81 merged 1 commit intonextcloud:masterfrom
Xavierando:#33036-Set-default-expiration-date-(shareapiDefaultExpireDate)
Conversation
szaimen
requested review from
a team,
CarlSchwan,
PVince81,
skjnldsv and
szaimen
and removed request for
a team
come-nc
approved these changes
Sep 1, 2022
Pytal
approved these changes
Sep 1, 2022
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Member
|
@Xavierando nice catch! thanks a lot |
Contributor
|
This is from here: #31194 (review) Thank you for testing and fixing this! |
Contributor
|
Backport to 24? |
Contributor
|
/backport to stable24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two input with same id and content
probably a never done clean up after a duplication of the line of code for beautify
#33036