Closed
Conversation
juliusknorr
requested review from
a team,
CarlSchwan,
PVince81,
come-nc and
skjnldsv
and removed request for
a team
CarlSchwan
reviewed
Jul 15, 2022
CarlSchwan
approved these changes
Jul 15, 2022
Contributor
|
Possible performance regression detected Show Output |
Member
This bot is not working correctly :( |
juliusknorr
force-pushed
the
techdebt/nouserexception
branch
from
55bffd4 to
d8e6255
Compare
Member
Author
|
Failures don't seem related, but re-triggered failed jobs. |
come-nc
reviewed
Sep 1, 2022
| * @throws LockedException | ||
| * @throws PreConditionNotMetException | ||
| * @throws NoUserException | ||
| * @throws \OCP\User\NoUserException |
Contributor
There was a problem hiding this comment.
Not consistent with having a use, you do not need to namespace it here
| * @param string $uid the username | ||
| * @return bool|string | ||
| * @throws NoUserException | ||
| * @throws \OCP\User\NoUserException |
| * | ||
| * @param string|IUser|null $user | ||
| * @throws \OC\User\NoUserException if the user is not available | ||
| * @throws \OCP\User\NoUserException if the user is not available |
Contributor
There was a problem hiding this comment.
Suggested change
| * @throws \OCP\User\NoUserException if the user is not available | |
| * @throws NoUserException if the user is not available |
| * @param string $userId user ID | ||
| * @return \OCP\Files\Folder | ||
| * @throws NoUserException | ||
| * @throws \OCP\User\NoUserException |
| */ | ||
| public function testLocalMountWhenUserDoesNotExist() { | ||
| $this->expectException(\OC\User\NoUserException::class); | ||
| $this->expectException(\OCP\User\NoUserException::class); |
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\OCP\User\NoUserException::class); | |
| $this->expectException(NoUserException::class); |
|
|
||
| public function testNullUserThrows() { | ||
| $this->expectException(\OC\User\NoUserException::class); | ||
| $this->expectException(\OCP\User\NoUserException::class); |
Contributor
There was a problem hiding this comment.
Suggested change
| $this->expectException(\OCP\User\NoUserException::class); | |
| $this->expectException(NoUserException::class); |
Contributor
|
/rebase |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud-command
force-pushed
the
techdebt/nouserexception
branch
from
d8e6255 to
cdd4db3
Compare
Merged
skjnldsv
added
2. developing
Member
|
Comments to address :) |
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Member
Author
|
Closing as I don't see time near to properly finish this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NoUserException might be useful for apps and is already used quite a lot as
IRootFolder::getUserFoldermay throw it.First commit is the new class, second refactors the server usages.