Set special header for 503 maintenance mode#33173
Merged
ChristophWurst merged 1 commit intomasterfrom Aug 10, 2022
Merged
Conversation
ChristophWurst
requested review from
CarlSchwan,
JuliaKirschenheuter,
blizzz,
julien-nc and
vitormattos
blizzz
reviewed
Jul 8, 2022
vitormattos
reviewed
Jul 11, 2022
vitormattos
left a comment
vitormattos
left a comment
There was a problem hiding this comment.
This will be very good to give a best feedback in integration tests of apps too.
Could implement tests in this PR to validate if this is working fine?
Member
Author
I would love to but this is base.php, the possibly most untestable piece of code :) |
This removes ambiguity with a 503 returned by app code, web server or similar. Front-end and clients can then handle this state accordingly. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/maintenance-mode-http-header
branch
from
8e90dd1 to
0ed987a
Compare
ChristophWurst
requested review from
ArtificialOwl,
blizzz,
marcelklehr,
miaulalala,
tcitworld and
vitormattos
tcitworld
approved these changes
Aug 9, 2022
Member
|
If this is merged, it would be nice to also have docs :) |
miaulalala
approved these changes
Aug 10, 2022
Member
Author
yes, but where? We have docs for OCS but nothing else that would cover related topics 🤷 Edit: opened nextcloud/documentation#9129. maybe I find a place another day |
Merged
This was referenced Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes ambiguity with a 503 returned by Nextcloud maintenance mode, some app's code, web server, proxy or
similar. Front-end and clients can then handle this state accordingly.
This will be helpful for nextcloud/mail#5714.