Merged
Conversation
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke and @LukasReschke to be potential reviewers |
Member
Author
|
Disabled coverage for now. Since it took > 2 hours. |
Member
Author
|
It seems we run out of terminal space. |
Coverage generation takes to long. So disabling for now.
Member
Author
|
Sine 7.0 has postgres failures. And I feel we should move to a full test coverage matrix anyways the situation now is the following (and passing at the moment).
So we still have some to add. (Also mariaDB makes sense). |
rullzer
added
3. to review
Member
|
makes sense 👍 and the change |
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
We don't have to build the request data again, it's already original in 'php://input' It is also better to send all headers. Perhaps we don’t need the code with “buildMultipartFormData” either Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now for real php 7.0 CI.
Lets see what drone tells us