Fix open_basedir issues by AWS SDK#32740
Fix open_basedir issues by AWS SDK#32740CarlSchwan merged 2 commits intonextcloud:masterfrom jasperweyne:patch-2
Conversation
This commit sets the 'use_aws_shared_config_files' option to false, in order to disable configuration loading from ~/.aws/config by the AWS SDK, specifically the S3Client. It is a continuation of #27040, as that PR only changed the behaviour of the CredentialsProvider; this change affects the ConfigurationProvider as well. Signed-off-by: Jasper Weyne <jasperweyne@gmail.com>
|
I see that the behat CI run fails, however I'm not exactly sure how this change affected those tests, as it should be relatively unrelated. Moreover, when running the test suite locally in docker, the same problem doesn't occur. Anyone any thoughts on this? I feel like this might be a magic bug and a rerun of the CI pipeline will "fix" this. However, if I messed something up, please point me in the right direction and I will fix it! |
|
Some of the integrations tests are also failing on master. Should be safe to ignore it. |
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Makes sense. Failing test definitely seems unrelated 👍
|
@juliushaertl Thanks for the review! I see that you've added the Nextcloud 25 milestone, I assume this is standard for a PR to master? In any case, I'd like to note that this fix would be applicable to versions 22-24 as well and shouldn't introduce any merge conflicts, as the relevant portion of code hasn't changed since (looking at the stable22 branch). |
|
@icewind1991 If you have any feedback, I'd love to hear it! |
|
Hi @icewind1991 do you perhaps have a chance to review this? I'd like to avoid this PR becoming stale. If there's anything I can do to help, please let me know! |
|
Hi @CarlSchwan , you've assigned the reviewers for this PR, but unfortunately @icewind1991 's review has been left open for more than two months now. I'm assuming he's unavailable to review this, can you perhaps assign another reviewer? |
PVince81
added
4. to release
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable24 |
|
/backport to stable23 |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
7 participants
This PR sets the 'use_aws_shared_config_files' option to false in the S3ConnectionTrait, in order to disable configuration loading from ~/.aws/config by the AWS SDK. It is a continuation of #27040, as that PR only changed the behaviour of the CredentialsProvider; this change affects the ConfigurationProvider as well, fully disabling any access to ~/.aws/config and solving all open_basedir issues. It intends to solve the issues stated in #23555.