Skip to content

Inputs.scss rewritting and optimisation#3187

Merged
MorrisJobke merged 19 commits intomasterfrom
inputs-scss-optimisation
Jan 22, 2017
Merged

Inputs.scss rewritting and optimisation#3187
MorrisJobke merged 19 commits intomasterfrom
inputs-scss-optimisation

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 21, 2017 •
edited
Loading

See #3121

cc @nextcloud/designers

@skjnldsv skjnldsv added 3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss labels Jan 21, 2017
@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Jan 21, 2017
@skjnldsv skjnldsv self-assigned this Jan 21, 2017
@skjnldsv skjnldsv force-pushed the inputs-scss-optimisation branch from 8ef1d06 to 8b11864 Compare January 21, 2017 04:38
@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 21, 2017 •
edited by skjnldsv
Loading

Go to personal page:

  • activity checkboxes are odd:

bildschirmfoto 2017-01-20 um 22 52 09

  • eye button for password input field is not within the input field anymore:

bildschirmfoto 2017-01-20 um 22 52 51

  • quota bar has a hovered state (but shouldn't):

bildschirmfoto 2017-01-20 um 22 53 26

Files app:

  • bottom shadow of the "switch to gallery" button on the right looks odd:

bildschirmfoto 2017-01-20 um 22 53 56

User management:

  • on hover over the groups and quota dropdowns the row is jumping around

Beside that: Awesome 🚀

@skjnldsv
Inputs.scss rewritting and optimisation, fix #3121
05f3990 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the inputs-scss-optimisation branch from 8b11864 to 05f3990 Compare January 21, 2017 17:18
@skjnldsv
Going back to svg for the checkmark and the mixed mark
f68ff25 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Removed old svg and added new ones
9689e46 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv mentioned this pull request Jan 21, 2017
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 21, 2017 •
edited
Loading

Okay, I decided to go with the svg background for the checkmark and the mixed one. Colors are still defined with css, it's easier for everyone, let's not complicate things too much! :)

capture d ecran_2017-01-21_19-13-45

@skjnldsv
Fixed show password
a4c74d5 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fixed strengthify wrapper
0f353b2 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Remove quota focus and unwanted state classes
7882976 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fixed multiselect focus
da4c6ab 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 21, 2017

@MorrisJobke Updated!
The gallery button is to be fixed on the gallery app :)

@skjnldsv
Fixed edit icon position
23dc0aa 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke
Copy link
Member

MorrisJobke commented Jan 21, 2017 •
edited by skjnldsv
Loading

  • download button on public link page looks out of place
    bildschirmfoto 2017-01-21 um 16 59 17

  • login page looks a broken:

bildschirmfoto 2017-01-21 um 17 00 56

  • password protected link page:

bildschirmfoto 2017-01-21 um 17 02 01

  • LDAP wizard: buttons look a bit too big compared to input (maybe okay)
  • LDAP wizard: copy button icon looks a bit too big:

bildschirmfoto 2017-01-21 um 17 04 02

Sorry @skjnldsv for not finding those things earlier.

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 22, 2017

@MorrisJobke Don't be sorry! :D
Good work takes time and thoroughness!

@skjnldsv
Fix login
466298d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke MorrisJobke added the 2. developing Work in progress label Jan 22, 2017
@MorrisJobke MorrisJobke removed the 3. to review Waiting for reviews label Jan 22, 2017
@skjnldsv
White checkmark fix
94a5290 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Disabled state fix
7fd2257 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Login and authenticate inputs fixes
ba8a9a9 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Select2 search input fix
56b9203 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix download button on public share
913834b 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fixed public share header buttons
6a617fa 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fixed sharing js
0a400c4 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix Navigation menu shadow and added rules for icon in button
17f8067 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fixed public share download button
4c47b8e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 22, 2017

@MorrisJobke ldap will be fixed in #2529 when I will be done with scss (we're close :D )

Everything else have been fixed.
More reviews? ❤️

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 22, 2017
@skjnldsv
App navigation utils buttons shadow fix
08361e6 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
LukasReschke
LukasReschke approved these changes Jan 22, 2017
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in Chrome and Safari here. 👍 🚀

@MorrisJobke MorrisJobke mentioned this pull request Jan 22, 2017
Merged
2 tasks
MorrisJobke
MorrisJobke approved these changes Jan 22, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and works here fine 👍 (even in IE11)

@MorrisJobke MorrisJobke merged commit 0d6e3ca into master Jan 22, 2017
@MorrisJobke MorrisJobke deleted the inputs-scss-optimisation branch January 22, 2017 17:41
This was referenced Jan 22, 2017
Closed
Merged
@ChristophWurst ChristophWurst mentioned this pull request Jan 23, 2017
Merged
@eppfel eppfel mentioned this pull request Jan 23, 2017
Closed
@skjnldsv skjnldsv mentioned this pull request Jan 23, 2017
Closed
@eppfel eppfel mentioned this pull request Jan 23, 2017
Closed
@skjnldsv skjnldsv mentioned this pull request Feb 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@Henni Henni Awaiting requested review from Henni

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@eppfel eppfel Awaiting requested review from eppfel

@blizzz blizzz Awaiting requested review from blizzz

@Espina2 Espina2 Awaiting requested review from Espina2

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @MorrisJobke @LukasReschke