Set oc_share_external.name column length to 4000 to remove arbitrary …#31827
Merged
Set oc_share_external.name column length to 4000 to remove arbitrary …#31827
Conversation
…limitation Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
a team,
PVince81,
blizzz and
vanpertsch
and removed request for
a team
szaimen
reviewed
Apr 4, 2022
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
increase the version number of files_sharing?
Contributor
|
@come-nc Was the 3rdparty bump intended? |
Contributor
Author
|
nope |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/allow-long-filename-in-share-external
branch
from
0a6ae20 to
c020b01
Compare
blizzz
approved these changes
Apr 4, 2022
blizzz
reviewed
Apr 4, 2022
| /** @var ISchemaWrapper $schema */ | ||
| $schema = $schemaClosure(); | ||
|
|
||
| $table = $schema->getTable('share_external'); |
Member
There was a problem hiding this comment.
wondering whether this table could be missing (defensive thinking), but seems quite quite unlikely.
Contributor
Author
There was a problem hiding this comment.
If it is missing something is off and we do want the migration to fail.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
Failures unrelated |
Contributor
Author
|
@PVince81 Should we backport this? |
Member
this would likely make minor upgrade slower for not much benefit, so perhaps no |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…limitation
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com