Perform a limited filesystem setup when getting share source#31773
Merged
Perform a limited filesystem setup when getting share source#31773
Conversation
icewind1991
requested review from
a team,
ArtificialOwl,
PVince81 and
come-nc
and removed request for
a team
come-nc
reviewed
Mar 31, 2022
icewind1991
added
2. developing
icewind1991
force-pushed
the
share-limited-owner-setup
branch
2 times, most recently
from
c74e6ce to
5480d58
Compare
PVince81
approved these changes
Mar 31, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 code looks good, see code scanning issues if applicable
icewind1991
force-pushed
the
share-limited-owner-setup
branch
from
5480d58 to
7f4ce2d
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-limited-owner-setup
branch
2 times, most recently
from
ec6eb43 to
7c367b6
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
share-limited-owner-setup
branch
from
7c367b6 to
d5953e5
Compare
Member
Author
|
CI has no more nitpicks |
icewind1991
added
3. to review
8 tasks
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MountManagerto allow getting mounts by providergetByIdimplementation to not perform a full filesystem setup if not neededgetByIdonLazyUserFolderwithout constructing the actual user folder.findByStorageIdThis saves having to do a full filesystem setup in order to get the source of a share, resulting in a significant reduction in database requests when handling shared storages.