Replace deprecated String.prototype.substr()#31699
Closed
CommanderRoot wants to merge 5 commits intonextcloud:masterfrom
CommanderRoot:refactor/rm-deprecated-substr
Closed
Replace deprecated String.prototype.substr()#31699CommanderRoot wants to merge 5 commits intonextcloud:masterfrom CommanderRoot:refactor/rm-deprecated-substr
CommanderRoot wants to merge 5 commits intonextcloud:masterfrom
CommanderRoot:refactor/rm-deprecated-substr
Conversation
Member
|
/compile amend / |
Member
|
/compile amend / |
Merged
Author
|
I have rebased the PR on current master and fixed the merge conflict |
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Merged
.substr() is deprecated so we replace it with .slice() or .substring() which work similarily but aren't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
.substr() is deprecated so we replace it with .slice() which work similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
.substr() is deprecated so we replace it with .slice() which work similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
Author
|
/compile amend / |
Member
|
far too much conflicts, feel free to run your bot again and create a new PR @CommanderRoot :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() or String.prototype.substring() which work similarily but aren't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.