Skip import of current calendar on error#31690
Merged
Conversation
Pytal
added
bug
3. to review
Pytal
requested review from
blizzz and
icewind1991
and removed request for
a team
Pytal
force-pushed
the
fix/throw-import-calendar-error
branch
2 times, most recently
from
3545c27 to
9dfa58b
Compare
Pytal
changed the title
tcitworld
approved these changes
Mar 24, 2022
come-nc
reviewed
Mar 24, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Not clear to me what this PR does.
come-nc
reviewed
Mar 24, 2022
Merged
Pytal
force-pushed
the
fix/throw-import-calendar-error
branch
2 times, most recently
from
f035cb4 to
c68899d
Compare
Pytal
force-pushed
the
fix/throw-import-calendar-error
branch
2 times, most recently
from
2989d0f to
39a5f77
Compare
come-nc
approved these changes
Mar 29, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Appart from verbose output question, fine by me.
artonge
reviewed
Mar 29, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/throw-import-calendar-error
branch
from
39a5f77 to
cdb93e7
Compare
Member
Author
Tracking here nextcloud/user_migration#68 |
Pytal
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip importing current calendar on error by throwing to stop continued calendar object imports in the foreach loops and move onto import of next calendar