Automatically cut the token name on the first level#31688
Merged
nickvergessen merged 2 commits intomasterfrom Mar 24, 2022
Merged
Automatically cut the token name on the first level#31688nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
ChristophWurst,
icewind1991,
max-nextcloud and
miaulalala
This was referenced Mar 23, 2022
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
I can confirm this fixes the failing cypress runs in text. I do not (yet) understand the implications of these changes. Mainly wondering if truncated names will always be unique. But i won't be able to think this through tonight. So just commenting and not approving.
ChristophWurst
approved these changes
Mar 24, 2022
Member
Author
It's just the labels shown in the list of index.php/settings/user/security |
max-nextcloud
approved these changes
Mar 24, 2022
Contributor
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Okay... since the name is just for identifying the source of the token and tokens are not identified by it this seems save to me.
nickvergessen
deleted the
bugfix/31658/automatically-cut-the-token-name-on-first-level
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #31658