Enforce primary keys as they are required to be performant in MySQL c…#31513
Merged
nickvergessen merged 2 commits intomasterfrom Mar 15, 2022
Merged
Enforce primary keys as they are required to be performant in MySQL c…#31513nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
…lusters Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
nickvergessen
requested review from
a team,
ArtificialOwl,
icewind1991 and
skjnldsv
and removed request for
a team
nickvergessen
added
2. developing
Member
Author
|
Test needs adjusting |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
PVince81
approved these changes
Mar 15, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍
we're not in feature freeze yet and after feature freeze we also freeze the APIs, so that's when app developers still have time to stabilize their apps while we go into beta
in the worst case if too many complains we can always revert before final
CarlSchwan
approved these changes
Mar 15, 2022
PVince81
added
4. to release
This was referenced Mar 15, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lusters
We are pretty close already to 24, so I'm also fine with delaying this until 25