Extract request id handling to dedicated class so it can be injected without DB dependency#31235
Conversation
CarlSchwan
left a comment
There was a problem hiding this comment.
Tests needs to be adapted, but other than a few small nitpicks this looks fine to me.
In some ways, this feels a bit like duplicated work with #30823 since the requests are also stored with the requested (and arguments + execution time) there :/
We might want to discuss how we want to move forward since there is also OCP\Diagnostics too that also logs queries and having 3 DB requests loggers is maybe a bit too much
Happy to talk about it. The problem is the profiler only helps in an isolated testing case. There is no way to e.g. monitor the full company call with it.
That's also right. I need to checkout the Diagnostics stuff again what it does and can do. |
…manually Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
a30a3a2 to
d078d53
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Logs before (with
query_log_file):Logs after (with
query_log_fileandquery_log_file_requestid=== yes)Required for more in depth debugging on parallel requests