Merged
Conversation
CarlSchwan
force-pushed
the
fix/admin-jquery-loading
branch
from
202ad84 to
da8fa76
Compare
CarlSchwan
requested review from
a team,
PVince81,
artonge and
skjnldsv
and removed request for
a team
artonge
approved these changes
Feb 14, 2022
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Nice, how many warnings does this remove? 😄
Member
Author
Not enough, still so many to go 😜 |
MichaIng
approved these changes
Feb 15, 2022
Contributor
|
Arf, need rebase |
CarlSchwan
force-pushed
the
fix/admin-jquery-loading
branch
from
da8fa76 to
0c138d8
Compare
Member
Author
|
When rebasing I noticed, I had a bit more changes locally to fix one issue with the enabling and disabling apps. Now errors are properly handled and most importantly when enabling an app there is no error anymore. I moved the entire rebuild-navigation method to webpack and ported it to vanillajs. I also ported to @nextcloud/dialog |
MichaIng
reviewed
Feb 16, 2022
artonge
reviewed
Feb 16, 2022
CarlSchwan
force-pushed
the
fix/admin-jquery-loading
branch
from
0c138d8 to
a6b5dae
Compare
* Move admin.js to webpack, so that this use the bundled jquery files instead of the deprecated window.$ Also fixing formatting * Remove log.js that seems to be from a time where logreader was bundled with server and I couldn't find an usage of it anymore * Fix recent regression in rebuild navigation function (now not depending on jquery anymore and bundled by webpack). Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/admin-jquery-loading
branch
from
b576cef to
e1f8b09
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move admin.js to webpack, so that this uses the bundled jquery files
instead of the deprecated window.$ Also fixing formatting
Remove log.js that seems to be from a time when logreader was bundled
with server and I couldn't find an usage of it anymore