Fix: Birthday events missing after reimporting contacts#30974
Merged
szaimen merged 1 commit intonextcloud:masterfrom Feb 3, 2022
Merged
Fix: Birthday events missing after reimporting contacts#30974szaimen merged 1 commit intonextcloud:masterfrom
szaimen merged 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
max65482
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
Contributor
Author
|
These steps may help you to reproduce the issue:
|
ChristophWurst
approved these changes
Feb 2, 2022
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Makes sense to bypass the trash bin for these auto generated events
ChristophWurst
added
feature: caldav
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
Member
Impressive first pull request. Cheers! |
miaulalala
approved these changes
Feb 2, 2022
Contributor
|
⚙️ failure unrelated |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Member
|
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue reported in nextcloud/calendar: Some contact birthdays do not show up in the birthday calendar. It seems that a birthday event is not deleted permanently once a contact is deleted. The event remains in the trash bin. When a contact is reimported (with the same UID), the event cannot be recreated due to conflicting UIDs.
This is fixed by deleting birthday events permanently. Please review all 4 occurrences in
BirthdayService.php.Fixes nextcloud/calendar#3914