Hash job argument

[juliusknorr]

Based on #30358

Fixes #28467

Adding a hashed argument column in order to allow to check if a job already exists with an indexed SQL query instead of filtering by the content of the varchar(4000) argument column.

@nickvergessen @skjnldsv The update time seems pretty reasonable to me when doing some tests with fake data, but if there are any concerns on having that done in the migration itself, we could have a separate occ command and allow admins to do this separate from the upgrade. Any objections on that?

# 56.560 rows, short argument text with random data
MariaDB [nextcloud]> update oc_jobs set argument_hash = md5(argument);
Query OK, 56560 rows affected (1.584 sec)
Rows matched: 102490  Changed: 56560  Warnings: 0

# 1.566.125 rows, 3000 character argument with random data
MariaDB [nextcloud]> update oc_jobs set argument_hash = md5(argument);
Query OK, 1566125 rows affected (8 min 53.272 sec)
Rows matched: 1668594  Changed: 1566125  Warnings: 0

[nickvergessen]

we could have a separate occ command and allow admins to do this separate from the upgrade. Any objections on that?

Yes, no one will run a manual command after the update. When it should only take a couple of seconds I would say let's do it with a sorry, but we can't help it.

[nickvergessen]

LGTM

[CarlSchwan]

/backport to stable23

[CarlSchwan]

/backport to stable22

[CarlSchwan]

/backport to stable21

[nickvergessen]

Bumped the autoloader

[CarlSchwan]

Test failing are unrelated to this PR and I'm working on it

[skjnldsv]

executeStatement is not available in stable21

[skjnldsv]

cc @CarlSchwan

[nickvergessen]

Still the correct way forward, but stable21 backport should be adjusted then

[skjnldsv]

I'm very surprised this was not caught on the 21 backport CI

[nickvergessen]

We don't have CI which runs all the migrations and there is no test for it.

Always had the idea of installing base-ref in an integration test and then performing an upgrade

[skjnldsv]

But wouldn't psalm catch a usage of a non-existent method?

[nickvergessen]

That's right 🤔