Merged
Conversation
backportbot-nextcloud
bot
requested review from
PVince81,
Pytal,
artonge,
jancborchardt,
nimishavijay and
szaimen
nextcloud-command
force-pushed
the
backport/30420/stable21
branch
from
78f2719 to
5cd2bee
Compare
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
szaimen
force-pushed
the
backport/30420/stable21
branch
from
5cd2bee to
2323fd1
Compare
Contributor
|
/compile amend / |
Contributor
|
Seems like the compile bot fails again because it uses npm version 16... |
Contributor
|
/compile amend / |
Member
|
You managed it by bumping npm/node temporarily, right? Is this assured to not cause webpack diffs when reverting npm/node? Or is the current diff in tests even a result of this 🤔? So maybe it needs to be bumped permanently? |
Contributor
Probably yes but to which version? Node 12 with npm 6? |
Member
|
14/7 worked before, but if 12/6 works as well then it is probably better to bump it as little as possible. |
Contributor
|
/compile amend / |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/30420/stable21
branch
from
e97174a to
a1fc749
Compare
szaimen
approved these changes
Jan 8, 2022
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I changed the engines in package.json now to
"node": "^12.0.0",
"npm": "^6.0.0"
Seems like it works now :)
szaimen
added
3. to review
skjnldsv
approved these changes
Jan 8, 2022
szaimen
added
4. to release
Contributor
|
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #30420