Sort app scripts topologically by its dependencies

[mejo-]

Implement a proper topological sorting algorithm. Based on the
implementation by https://github.com/marcj/topsort.php

Throws a CircularDependencyException if a circular dependency is
detected.

Fixes: #30278

[mejo-]

Not sure whether we want the CircularDependencyException to be thrown. We also could skip that if we don't consider circular dependencies a problem (in certain cases they can result in broken dependency chains).

[mejo-]

Not sure whether we want the CircularDependencyException to be thrown. We also could skip that if we don't consider circular dependencies a problem (in certain cases they can result in broken dependency chains).

Thinking about it again, it's not a good idea to fail hard here by throwing an exception and we should just log an error instead. Agreed?

[mejo-]

Thinking about it again, it's not a good idea to fail hard here by throwing an exception and we should just log an error instead. Agreed?

I removed the CircularDependencyException. Instead, the circular dependency is now merely logged as an error if detected.

see Christoph remarks

[skjnldsv]

This took a crazy turn! Code looks good, tests too! 🚀
Awesome work!

[juliusknorr]

Psalm failure unrelated

[ChristophWurst]

👍

[mejo-]

This took a crazy turn!

Soooo true 🙈 🤪

I wouldn't have expected this to become such a ride. Thanks a lot to @ChristophWurst and @skjnldsv for guiding me!

[mejo-]

Seems like I'm not allowed to merge - maybe due to the (unrelated) psalm test failures? 🤔 Could someone with super powers merge? 😬

[CarlSchwan]

Unfortunately, this causes an psalm warning, since now OCP depends on OC. This wasn't found earlier since psalm was broken but it appear on #30508

I'm not sure if we can ignore this issue and just add it to the baseline or if we should fix it

[juliusknorr]

Fine to add to the baseline from my perspective as it is only used in the method implementation and not exposed in any kinds.