Closed
Conversation
Memcached and Redis are intances of IMemcache. That interface is superior as it has the fancy inc and dec helpers. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
enhancement
3. to review
ChristophWurst
requested review from
ArtificialOwl,
come-nc and
nickvergessen
and removed request for
a team
Contributor
|
Lots of tests needs to be adapted it seems. I do not understand the psalm error: "Type OCP\IMemcache for $lockingCache is always OCP\IMemcache". |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
come-nc
reviewed
Dec 6, 2021
Comment on lines
+321
to
+322
| $cache = $this->cache = $this->createMock(IMemcache::class); | ||
| ; |
Contributor
There was a problem hiding this comment.
Suggested change
| $cache = $this->cache = $this->createMock(IMemcache::class); | |
| ; | |
| $cache = $this->cache = $this->createMock(IMemcache::class); |
come-nc
reviewed
Dec 6, 2021
Comment on lines
+88
to
+89
| $this->cache = $this->cache = $this->createMock(IMemcache::class); | ||
| ; |
Contributor
There was a problem hiding this comment.
Suggested change
| $this->cache = $this->cache = $this->createMock(IMemcache::class); | |
| ; | |
| $this->cache = $this->createMock(IMemcache::class); |
come-nc
reviewed
Dec 6, 2021
| public function testShouldMoveToTrash($mountPoint, $path, $userExists, $appDisablesTrash, $expected) { | ||
| $fileID = 1; | ||
| $cache = $this->createMock(ICache::class); | ||
| $cache = $this->cache = $this->createMock(IMemcache::class); |
Contributor
There was a problem hiding this comment.
Suggested change
| $cache = $this->cache = $this->createMock(IMemcache::class); | |
| $cache = $this->createMock(IMemcache::class); |
come-nc
requested changes
Dec 6, 2021
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Seems like a case of batch replace gone wrong.
Lots of superflous "$this->cache =" and duplicated ";".
nickvergessen
added
1. to develop
Merged
Merged
ChristophWurst
deleted the
enhancement/cache-factory-distributed-memcache
branch
Member
Author
|
I've raised #31787 so this can be picked up later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memcached and Redis are instances of IMemcache. That interface is
superior as it has the fancy inc and dec helpers.
For app development it's nice if we can use memcache without an instanceof check.