Replace CalDAV availability component with component lib#29796
Merged
ChristophWurst merged 1 commit intomasterfrom Feb 17, 2022
Merged
Replace CalDAV availability component with component lib#29796ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Merged
1 task
a34539d to
b119295
Compare
b119295 to
1e4926e
Compare
1e4926e to
51c457d
Compare
miaulalala
requested changes
Jan 3, 2022
Contributor
miaulalala
left a comment
There was a problem hiding this comment.
I can't save working hours any more:
could not save availability TypeError: Object(...) is not a function
at _callee2$ (CalendarService.js:134)
at tryCatch (runtime.js:63)
at Generator.invoke [as _invoke] (runtime.js:294)
at Generator.next (runtime.js:119)
at asyncGeneratorStep (CalendarService.js:19)
at _next (CalendarService.js:21)
at CalendarService.js:21
at new Promise (<anonymous>)
at CalendarService.js:21
at _saveScheduleInboxAvailability (CalendarService.js:152)```
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
miaulalala
approved these changes
Jan 3, 2022
Contributor
|
Works now! |
51c457d to
5dcc47e
Compare
Contributor
|
Drone failure unrelated. |
5dcc47e to
d2666b5
Compare
Member
Author
|
/compile amend / |
d2666b5 to
2e9af65
Compare
Member
Author
doesn't work anymore, yay. |
Member
Author
Member
Done! Tested and it works fine again. |
Member
|
I tried to rebase and have bad news: server requires @nextcloud/vue v5 but calendar-availability-vue requires v4.2 as a peer. We have to update and release the lib first. |
26 tasks
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
20dfee7 to
daf1b5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires nextcloud/calendar-availability-vue#6
/settings/user/groupwareshould work like before. This is an internal clean-up/refactoring to deduplicate some code.This also fixes the regression from #30020 that all of the personal settings front-end was missing.