Avoid PHP errors when the LDAP attribute is not found#29180
Merged
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
CarlSchwan
reviewed
Oct 12, 2021
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
blizzz
reviewed
Oct 12, 2021
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
just that one thing pointed out :)
…_LDAP\Access Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
bug/27798/fix-php-error-in-ldap-access
branch
from
9e64275 to
d189a23
Compare
Contributor
Author
|
This is again ready for review/merge, I did what I could to improve the situation on the logger front, the rest will need a DI refactor of the user_ldap application. |
blizzz
approved these changes
Oct 14, 2021
come-nc
force-pushed
the
bug/27798/fix-php-error-in-ldap-access
branch
from
3bc2b97 to
bb17438
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
bug/27798/fix-php-error-in-ldap-access
branch
from
bb17438 to
f9e6f2e
Compare
skjnldsv
approved these changes
Oct 15, 2021
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Contributor
Author
|
/backport to stable22 |
Contributor
Author
|
/backport to stable21 |
Contributor
Author
|
/backport to stable20 |
This was referenced Oct 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #27798
This will avoid the PHP error. It will still be an error because the ldap attribute used to name the user internally cannot be found or is empty, but it won’t be a PHP error anymore.