[stable22] Delete S3 versions in rmdir#29171
Closed
backportbot-nextcloud[bot] wants to merge 1 commit intostable22from
Closed
[stable22] Delete S3 versions in rmdir#29171backportbot-nextcloud[bot] wants to merge 1 commit intostable22from
backportbot-nextcloud[bot] wants to merge 1 commit intostable22from
Conversation
When deleting a complete folder in a bucket that has versioning enabled, also make sure to delete all associated versions and delete markers Signed-off-by: Vincent Petry <vincent@nextcloud.com>
backportbot-nextcloud
bot
requested review from
CarlSchwan,
PVince81,
artonge,
icewind1991,
juliusknorr and
kesselb
Member
Member
|
Isn't this two different things? |
Member
slightly, but I had the feeling that the other backport was forgotten and would be useful as well and just now I'm not sure if this is a good approach because versions will get lost, see the new found issue: nextcloud/files_versions_s3#13 |
PVince81
requested changes
Oct 12, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
blocking for now
we are evaluating another approach because this one will lose the versions
I'll make a ticket when ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #29165