Skip to content

[stable21] Add database ratelimiting backend#28815

Merged
blizzz merged 1 commit intostable21from
backport/28728/stable21
Sep 13, 2021
Merged

[stable21] Add database ratelimiting backend#28815
blizzz merged 1 commit intostable21from
backport/28728/stable21

Conversation

@LukasReschke
Copy link
Member

@LukasReschke LukasReschke commented Sep 13, 2021

Backport of #28728

LukasReschke
LukasReschke commented Sep 13, 2021
View reviewed changes
@LukasReschke
Copy link
Member Author

LukasReschke commented Sep 13, 2021 •
edited
Loading 

/home/runner/work/server/server/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php:78:6:error - UndefinedInterfaceMethod: Method OCP\DB\QueryBuilder\IQueryBuilder::executeStatement does not exist
/home/runner/work/server/server/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php:90:18:error - UndefinedInterfaceMethod: Method OCP\DB\QueryBuilder\IQueryBuilder::executeQuery does not exist
/home/runner/work/server/server/lib/private/Security/RateLimiting/Backend/DatabaseBackend.php:122:6:error - UndefinedInterfaceMethod: Method OCP\DB\QueryBuilder\IQueryBuilder::executeStatement does not exist

Please run: bash build/autoloaderchecker.sh

LukasReschke
LukasReschke commented Sep 13, 2021
View reviewed changes
Copy link
Member Author

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan:

  • Disable the memory cache in config.php
  • Enable the "Q&A Testing App" in the app settings
  • Go to /index.php/apps/testing/userAndAnonProtected and click a few times. Verify that the requests fails due to hitting the ratelimit.
  • Verify that expired ratelimit entries are removed on requests

@LukasReschke
Add database ratelimiting backend
f416cac 
In case no distributed memory cache is specified this adds
a database backend for ratelimit purposes.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke force-pushed the backport/28728/stable21 branch from 74bfeb1 to f416cac Compare September 13, 2021 14:46
@LukasReschke LukasReschke marked this pull request as ready for review September 13, 2021 15:01
@blizzz blizzz merged commit 7997483 into stable21 Sep 13, 2021
@blizzz blizzz deleted the backport/28728/stable21 branch September 13, 2021 16:07
@blizzz blizzz mentioned this pull request Sep 23, 2021
Merged
8 tasks
@wehrlean wehrlean mentioned this pull request Feb 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@Pytal Pytal Pytal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LukasReschke @blizzz @Pytal