Conversation
Contributor
Author
|
@ChristophWurst I'm not sure if adding the OPT-PARTICIPANT ROLE to the check would be beneficial. What do you think? |
kesselb
reviewed
Sep 1, 2021
ChristophWurst
approved these changes
Sep 2, 2021
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
But remove the unrelated new file :)
Member
so that optional participants also get an invite when no RSVP is set? |
02b7fe2 to
f5b287a
Compare
Contributor
Author
|
@ChristophWurst yes - I'm not sure if this is neccessary or even wanted, but it makes sense to me. |
Member
|
some insights on the seemingly random psalm security check failure
|
Signed-off-by: Anna Larch <anna@nextcloud.com>
06cca75 to
56cc01c
Compare
Member
|
/backport to stable22 |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
kesselb
approved these changes
Sep 7, 2021
This was referenced Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To compensate for the missing RSVP from Mail Clients like Apple Mail and Thunderbird, also look at the role of the attendee to determine if they should receive a link for the event.
Fixes #21189