NMC-533 Set new folder name inline#28645
Closed
TSI-kavitasonawane wants to merge 9 commits intonextcloud:masterfrom
Closed
NMC-533 Set new folder name inline#28645TSI-kavitasonawane wants to merge 9 commits intonextcloud:masterfrom
TSI-kavitasonawane wants to merge 9 commits intonextcloud:masterfrom
Conversation
…ment creation Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
96e4058 to
7e29bd1
Compare
juliusknorr
reviewed
Aug 31, 2021
juliusknorr
reviewed
Aug 31, 2021
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
Member
@TSI-kavitasonawane The folder changes works great. But the file one is more subtle. |
Member
|
Also, JSUnit fails: TOTAL: 6 FAILED, 809 SUCCESS
1) sets default text in field
OCA.Files.NewFileMenu New file/folder
Expected 0 to equal 2.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:73:26)
Expected undefined to equal 'New folder'.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:74:25)
2) prevents entering invalid file names
OCA.Files.NewFileMenu New file/folder
Expected false to equal true.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:81:42)
3) prevents entering file names that already exist
OCA.Files.NewFileMenu New file/folder
Expected false to equal true.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:89:42)
4) creates directory when clicking on create directory field
OCA.Files.NewFileMenu New file/folder
Expected 'New folder' to equal 'some folder'.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:99:51)
5) calls action handler when clicking on custom item
OCA.Files.NewFileMenu custom entries
Expected 'New text file.txt' to equal 'some name'.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:144:42)
6) switching fields removes the previous form
OCA.Files.NewFileMenu custom entries
Expected 0 to equal 1.
at Object.<anonymous> (apps/files/tests/js/newfilemenuSpec.js:148:41) |
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
artonge
requested changes
Sep 2, 2021
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
Member
|
Jsunit needs to be adapted again and tabs indent is still not fixed :) |
Member
|
100% Agree @juliushaertl |
Member
|
Filed an issue about it in #31414 |
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Close #28669
Add button folder creation changes:
Add button text document creation changes: