Update TXT.php

[MasahikoSada]

To support files encoded by Shift-JIS(Japanese) , GB2312 and GBK(Chinese) .

[erhuz]

Would be nice to indent row 70 and remove an indentation from row 69.

[kesselb]

Thanks 👍

I would say the issue is not the encoding but the font used for txt preview NotoSans-Regular.ttf

On the other hand imagettftext expects a utf8 encoded string as text anyway so a explicit is probably not wrong. Yet https://www.php.net/manual/en/function.mb-convert-encoding should be easier to use here as the from encoding is detected automatically.

[kesselb]

Thanks @MasahikoSada, can you provide a simple text document or a string with some characters to test the change?

[MasahikoSada]

Thanks @MasahikoSada, can you provide a simple text document or a string with some characters to test the change?

@kesselb
Thanks for your reply.

This is a sample file endoced by SHIFT-JIS(ANSI).
https://1drv.ms/t/s!AnT4d94afUwMhYJsm8nD3x9bDGas8w?e=LDAdM7

Screen shot is here.
https://1drv.ms/u/s!AnT4d94afUwMhYJtdnIDR17FOPaCCg?e=OqgYbJ

[kesselb]

Hi,

uploaded the test file to my dev instance to generate the preview images. Is one of the previews the expected outcome?

1. no patch

2. version with iconv

3. version with mb_convert_encoding

[MasahikoSada]

Hi,

uploaded the test file to my dev instance to generate the preview images. Is one of the previews the expected outcome?

Hi,
No one is the expected output, but I think that the version 2's encode is proper one.
The only issue of version 2 is just the font.

Can you show me the version with mb_convert_encoding and 'auto' option.
I think it will be as same as version 2.

[kesselb]

Hey,

$content = ���肪�Ƃ��B ����͓��{�ꕶ���̃e�X�g�t�@�C���ł��B

mb_convert_encoding($content, 'UTF-8', 'auto'); => false

Blank preview image

mb_convert_encoding($content, 'UTF-8', 'SJIS-win, GB2312, GBK, UTF-8, WINDOWS-1252, ISO-8859-15, ISO-8859-1, ASCII') => ありがとう。 これは日本語文字のテストファイルです。

[MasahikoSada]

Hey,

$content = ���肪�Ƃ��B ����͓��{�ꕶ���̃e�X�g�t�@�C���ł��B

mb_convert_encoding($content, 'UTF-8', 'auto'); => false

Blank preview image

mb_convert_encoding($content, 'UTF-8', 'SJIS-win, GB2312, GBK, UTF-8, WINDOWS-1252, ISO-8859-15, ISO-8859-1, ASCII') => ありがとう。 これは日本語文字のテストファイルです。

Thanks for your comment.
When 'auto' is set, I think it depends on 'mbstring.language' in php.ini .
When I set mbstring.language=japanese, the output is expected one.