Improve limit for single s3 put uploads#28542
Merged
juliusknorr merged 1 commit intomasterfrom Dec 29, 2021
Merged
Conversation
4aa47d6 to
10ec8a1
Compare
CarlSchwan
reviewed
Dec 29, 2021
| use Aws\Credentials\Credentials; | ||
| use Aws\Exception\CredentialsException; | ||
| use Aws\S3\Exception\S3Exception; | ||
| use Aws\S3\MultipartUploader; |
artonge
approved these changes
Dec 29, 2021
Contributor
artonge
left a comment
There was a problem hiding this comment.
Some php-cs warnings, else, looks good.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
aeeb17f to
2aac757
Compare
CarlSchwan
approved these changes
Dec 29, 2021
Member
Author
|
Failure unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #27877 to further address the comments from @kesselb
100 MB was picked as the default, as per AWS S3 recommendation to make use of multipart upload for files larger than that:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpuoverview.html
Memory overhead is the actual file size which would fit our recommended php memory limit of 512 MB still fairly easy.