use case insensitive like when limiting search to jail#28476
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
added
2. developing
icewind1991
requested review from
ChristophWurst and
PVince81
and removed request for
PVince81
Member
Author
|
/backport to stable22 |
ChristophWurst
approved these changes
Aug 23, 2021
PVince81
approved these changes
Aug 24, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 makes sense
the case insensitivity is only required for the original search string, not the post-filtering
PVince81
added
4. to release
Member
|
failing test unrelated, merging |
This was referenced Oct 5, 2021
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
Member
Author
|
21 and 20 are done with #29080 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case insensitivity isn't required and making the comparison case sensitive makes things easier for the database especially if we ever get a (partial) index on
path