Scan the shared external storage source on access#28377
Merged
Conversation
skjnldsv
added
bug
3. to review
icewind1991
previously requested changes
Aug 11, 2021
Member
icewind1991
left a comment
icewind1991
left a comment
There was a problem hiding this comment.
This should instead be done by changing the Watcher returned by SharedStorage::getWatcher.
It currently returns a NullWatcher since it assumes that the share source handles it's updating (which is true for non-external-storage shares).
This comment has been minimized.
This comment has been minimized.
skjnldsv
force-pushed
the
fix/shared-ext-storage-scan
branch
from
446879a to
643f39e
Compare
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
Member
|
@CarlSchwan can you check if this might be related to the issue you're looking into ? seems it's also about a mount not being considered properly. |
PVince81
approved these changes
Aug 26, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 looks fine to me, but would be good to get confirmation from @icewind1991 also
CarlSchwan
reviewed
Aug 26, 2021
icewind1991
previously requested changes
Aug 26, 2021
skjnldsv
force-pushed
the
fix/shared-ext-storage-scan
branch
from
643f39e to
8d65267
Compare
skjnldsv
force-pushed
the
fix/shared-ext-storage-scan
branch
from
8d65267 to
002e1a5
Compare
skjnldsv
force-pushed
the
fix/shared-ext-storage-scan
branch
from
002e1a5 to
fe44de4
Compare
Member
Author
|
Failures unrelated |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/shared-ext-storage-scan
branch
from
fe44de4 to
719480a
Compare
This was referenced Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23988
Regression from #22867